Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.7 #74

Merged
merged 6 commits into from
Feb 7, 2019
Merged

Support Python 3.7 #74

merged 6 commits into from
Feb 7, 2019

Conversation

dkfellows
Copy link
Member

This is how to do builds using Python 3.7 on Travis.

It doesn't work. @Christian-B was too clever by half in some of his classes. 😉

@dkfellows dkfellows added this to the 5.0.0 milestone Jan 29, 2019
@coveralls
Copy link

coveralls commented Jan 29, 2019

Pull Request Test Coverage Report for Build 683

  • 43 of 47 (91.49%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 91.805%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spinn_utilities/ranged/abstract_list.py 22 24 91.67%
spinn_utilities/ranged/abstract_sized.py 6 8 75.0%
Totals Coverage Status
Change from base Build 675: 0.02%
Covered Lines: 1994
Relevant Lines: 2172

💛 - Coveralls

@Christian-B
Copy link
Member

Looks like I fixed the key issues so once green can be merged.

Still recommend everyone looks at the files changed to understand the 3.7 monsters.

@dkfellows
Copy link
Member Author

Looks OK to me.

Next, we need to get the rest of the stack also tested with 3.7…

@Christian-B Christian-B mentioned this pull request Feb 7, 2019
@dkfellows dkfellows merged commit 69bfd85 into master Feb 7, 2019
@dkfellows dkfellows deleted the py3.7 branch February 7, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants