Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce copyright notices #86

Merged
merged 22 commits into from
Jul 12, 2019
Merged

Enforce copyright notices #86

merged 22 commits into from
Jul 12, 2019

Conversation

dkfellows
Copy link
Member

See SpiNNakerManchester/SupportScripts#17

This is the demonstration of what it takes to support RAT and get our house in order. In particular, see the .ratexcludes file and the changes to .travis.yml to call it (java and ant dependency, call support/rat.sh in two stages to set up — download — and do the check — run).

@coveralls
Copy link

Pull Request Test Coverage Report for Build 757

  • 9 of 15 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.1%) to 90.385%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spinn_utilities/make_tools/file_converter.py 9 15 60.0%
Totals Coverage Status
Change from base Build 748: -1.1%
Covered Lines: 2040
Relevant Lines: 2257

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 15, 2019

Pull Request Test Coverage Report for Build 837

  • 9 of 14 (64.29%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.457%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spinn_utilities/make_tools/file_converter.py 9 14 64.29%
Totals Coverage Status
Change from base Build 833: 0.03%
Covered Lines: 2341
Relevant Lines: 2532

💛 - Coveralls

.travis.yml Outdated Show resolved Hide resolved
@dkfellows dkfellows mentioned this pull request Jun 12, 2019
@dkfellows dkfellows requested a review from rowleya July 11, 2019 12:59
@dkfellows dkfellows added this to the 5.0.0 milestone Jul 11, 2019
Copy link
Member

@rowleya rowleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Happy for this to be merged if you are ready...

@dkfellows dkfellows changed the title Rat enforcement Enforce copyright notices Jul 12, 2019
@rowleya rowleya merged commit ce0fc70 into master Jul 12, 2019
@rowleya rowleya deleted the rat branch July 12, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants