All algorithms #88
Merged
All algorithms #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock of the code. variables renamed. etc. lots of dcumentation. etc etce tc
…d name of class mismatch
Pull Request Test Coverage Report for Build 768
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1028
💛 - Coveralls |
dkfellows
reviewed
Jul 8, 2019
spinn_utilities/executable_finder.py
Outdated
| @@ -56,20 +58,22 @@ def get_executable_path(self, executable_name): | |||
| return potential_filename | |||
|
|
|||
| # No executable found | |||
| return None | |||
| raise FailedToFindBinaryException( | |||
There was a problem hiding this comment.
Why are you introducing a new failure mode?
There was a problem hiding this comment.
better to fail before loading data. if you dont have a failure mode here. it causes some horrible error about flood filling None. fail fast and understandablly
Conflicts: spinn_utilities/ordered_default_dict.py
rowleya
approved these changes
Oct 18, 2019
Conflicts: spinn_utilities/ordered_default_dict.py
fixed issues with system prov folder
fixes to make it work for structural and makes the compressor and sorter work with vogals2011. it currently has 2 key components removed: the fake heap. and the bitfield sorter. as the sorter seem to cause very dodgy errors and i have not yet tested with the fake heap reinstalled. christian is currently looking at rewriting the sorter etc so that its more efficent and thus hopefully debugged in the process. this in theory though. should pass intergration tests
|
fixed elsewhere |
|
alas not. we do need this. at least for a file rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tie in for the project to test mapping algorithms. is a blind copy of c model with bitfields