Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the level of confusion in some GFE tests #116

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Conversation

dkfellows
Copy link
Member

Getting the placement to get the vertex to get the placement, or getting the ethernet chip coordinates to get the ethernet chip to get the ethernet chip coordinates? Yikes! Could we please find a few more mulberry bushes to drag this poor code around a few times?

Getting the placement to get the vertex to get the placement, or getting
the ethernet chip coordinates to get the ethernet chip to get the
ethernet chip coordinates? Yikes! Could we please find a few more
mulberry bushes to drag this poor code around a few times?
@dkfellows dkfellows added this to the 5.0.0 milestone Aug 7, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2012

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.058%

Totals Coverage Status
Change from base Build 1952: 0.0%
Covered Lines: 210
Relevant Lines: 599

💛 - Coveralls

@rowleya rowleya merged commit d53882c into master Aug 9, 2019
@rowleya rowleya deleted the reduce-the-silly branch August 9, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants