Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SkipTest must have a reason #1401

Merged
merged 1 commit into from
Oct 11, 2023
Merged

SkipTest must have a reason #1401

merged 1 commit into from
Oct 11, 2023

Conversation

Christian-B
Copy link
Member

Found by type Checking branches

unittest.SkipTest must have a reason

so raise_skiptest must have one too

part of SpiNNakerManchester/SpiNNUtils#248

@Christian-B Christian-B added bug blocker Do not release when one of these is open! labels Oct 11, 2023
@coveralls
Copy link

Coverage Status

coverage: 61.369%. remained the same when pulling 8b17cb3 on skip_test into c55ff8c on master.

@Christian-B Christian-B mentioned this pull request Oct 11, 2023
Merged
@Christian-B Christian-B merged commit aec1fda into master Oct 11, 2023
6 of 9 checks passed
@Christian-B Christian-B deleted the skip_test branch October 11, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rowleya rowleya

Labels
blocker Do not release when one of these is open! bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Christian-B @coveralls @rowleya