Updated to avoid issues of wrap around of timer #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could do with testing on any known error cases where the timer has wrapped in the past... |
Pull Request Test Coverage Report for Build 4106
💛 - Coveralls |
|
conflict need fixing |
fix_delay_between_spikes Conflicts: neural_modelling/src/neuron/c_main.c neural_modelling/src/neuron/neuron.c neural_modelling/src/neuron/neuron.h spynnaker/pyNN/models/spike_source/spike_source_poisson.py
|
Have updated this against current master and it certainly seems to fix the problems I've been seeing recently with timer tick callback warnings following multiple (serial) runs. Also worth noting that this doesn't seem to help with the issues of timer tick callback warnings that are currently present when running the Sudoku script. Probably also worth testing against other cases where these warnings have been known to happen in the past. |
…erManchester/sPyNNaker.git into fix_delay_between_spikes
Conflicts: spynnaker/pyNN/models/neuron/abstract_population_vertex.py spynnaker/pyNN/models/spike_source/spike_source_poisson_vertex.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid additional delays when the timer tick is close to over-running (or has overrun). It could create dropped packets in those circumstances (but then we are supposed to avoid those circumstances anyway).