Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Celltype to return DataHolder #117

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Changed Celltype to return DataHolder #117

merged 1 commit into from
Feb 20, 2018

Conversation

Christian-B
Copy link
Member

As the DataHolder does http://neuralensemble.org/docs/PyNN/reference/neuronmodels.html

celltype should return the DataHolder

@Christian-B Christian-B added this to the 5.0.0 milestone Feb 19, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 954

  • 7 of 9 (77.78%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.318%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spynnaker8/models/populations/population.py 7 9 77.78%
Totals Coverage Status
Change from base Build 932: 0.0%
Covered Lines: 1267
Relevant Lines: 2001
💛 - Coveralls

@alan-stokes alan-stokes merged commit 14dfd72 into master Feb 20, 2018
@alan-stokes alan-stokes deleted the change_celltype branch February 20, 2018 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alan-stokes alan-stokes

Labels
bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Christian-B @coveralls @alan-stokes