Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private variables #192

Merged
merged 8 commits into from
Jun 7, 2019
Merged

Private variables #192

merged 8 commits into from
Jun 7, 2019

Conversation

dkfellows
Copy link
Member

Companion PR for SpiNNakerManchester/sPyNNaker#592; see that for details

@dkfellows
Making variables more private than before
63b9c5b 
This is part of a plan to try to discourage users from poking their
fingers in where they don't belong. Anything in sPyNNaker's guts that
isn't part of PyNN (or our documented extensions to PyNN) is off-limits
and liable to change without warning!
@dkfellows
While there is a _population property, there isn't an _id
9f29422
@dkfellows
Stop infinite recursion
9b7be57
@dkfellows
Better testing
554ec62
@dkfellows
flake8
341ede0
@dkfellows dkfellows added this to the 5.0.0 milestone Feb 5, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2088

  • 119 of 159 (74.84%) changed or added relevant lines in 17 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 69.085%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spynnaker8/models/recorder.py 0 1 0.0%
spynnaker8/spinnaker.py 8 9 88.89%
spynnaker8/models/data_cache.py 17 19 89.47%
spynnaker8/models/synapse_dynamics/synapse_dynamics_static.py 4 6 66.67%
spynnaker8/models/synapse_dynamics/synapse_dynamics_stdp.py 4 6 66.67%
spynnaker8/models/synapse_dynamics/timing_dependence/timing_dependence_spike_pair.py 4 6 66.67%
spynnaker8/models/connectors/from_list_connector.py 4 7 57.14%
spynnaker8/utilities/log.py 1 4 25.0%
spynnaker8/models/synapse_dynamics/timing_dependence/timing_dependence_pfister_spike_triplet.py 0 6 0.0%
spynnaker8/models/synapse_dynamics/timing_dependence/timing_dependence_recurrent.py 0 6 0.0%
Totals Coverage Status
Change from base Build 2026: 0.03%
Covered Lines: 1457
Relevant Lines: 2109
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2088

  • 119 of 159 (74.84%) changed or added relevant lines in 17 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 69.085%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spynnaker8/models/recorder.py 0 1 0.0%
spynnaker8/spinnaker.py 8 9 88.89%
spynnaker8/models/data_cache.py 17 19 89.47%
spynnaker8/models/synapse_dynamics/synapse_dynamics_static.py 4 6 66.67%
spynnaker8/models/synapse_dynamics/synapse_dynamics_stdp.py 4 6 66.67%
spynnaker8/models/synapse_dynamics/timing_dependence/timing_dependence_spike_pair.py 4 6 66.67%
spynnaker8/models/connectors/from_list_connector.py 4 7 57.14%
spynnaker8/utilities/log.py 1 4 25.0%
spynnaker8/models/synapse_dynamics/timing_dependence/timing_dependence_pfister_spike_triplet.py 0 6 0.0%
spynnaker8/models/synapse_dynamics/timing_dependence/timing_dependence_recurrent.py 0 6 0.0%
Totals Coverage Status
Change from base Build 2026: 0.03%
Covered Lines: 1457
Relevant Lines: 2109
💛 - Coveralls

@rowleya rowleya merged commit 7ae5c7a into master Jun 7, 2019
@rowleya rowleya deleted the private-variables branch June 7, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowleya rowleya Awaiting requested review from rowleya

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dkfellows @coveralls @rowleya