Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal SpiceExpression #1

Merged
merged 2 commits into from
Mar 16, 2018
Merged

Proposal SpiceExpression #1

merged 2 commits into from
Mar 16, 2018

Conversation

svenboulanger
Copy link
Member

I saw a lot of warnings and code styling issues so I thought I'd clean up the code I originally wrote.

Copy link
Member

@marcin-golebiowski marcin-golebiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

public FunctionOperator(Func<Stack<double>, double> func)
: base(IdFunction, byte.MaxValue, false)
{
Function = func;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svenboulanger Please add null check

@svenboulanger svenboulanger merged commit 2448649 into master Mar 16, 2018
@svenboulanger svenboulanger deleted the spiceexpression branch March 16, 2018 12:13
marcin-golebiowski added a commit that referenced this pull request Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants