Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workspace path from Github default env variables #13

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

AngelOnFira
Copy link
Member

This closes #7. The GITHUB_WORKSPACE environment variable is provided to each Action, and should be used to know where the workspace is instead of hardcoding it.

I still have to test this to look at any potential ramifications from how the workflow is currently working for other repos.

@baileytincher
Copy link

This project seems abandoned. I forked and fixed the action https://github.com/marketplace/actions/create-dotenv-file

@AngelOnFira AngelOnFira merged commit b2cbcd0 into SpicyPizza:master Apr 18, 2021
@AngelOnFira AngelOnFira deleted the update-default-path branch April 18, 2021 20:46
@AngelOnFira
Copy link
Member Author

@baileytincher I took a look at some of your changes, they look pretty good! Sorry that I've been a bit absent from this repo - hopefully since I've resolved most of the items, I can now do releases a bit easier. If you're willing, it would be great to have a PR from you with your changes. If not, I'll just directly make a PR on my own, but it would be great to give you credit where it is due. Thanks for inspiring me to get back on my toes with this repo 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$GITHUB_WORKSPACE is not always the hard coded path
2 participants