Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit README and Dockerfile #34

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Conversation

Flaiers
Copy link
Contributor

@Flaiers Flaiers commented Nov 8, 2021

Hi. I remove useless file entrypoint.sh and implemented python file launch by pointing to python root. fixed the structure inside the container.

Hi. I remove useless file entrypoint.sh and implemented python file launch by pointing to python root. fixed the structure inside the container.
@Flaiers Flaiers mentioned this pull request Nov 8, 2021
Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! I have a few requested changes + discussion points. But I feel like this will help in a few ways, especially with the time needed to run the action.

Dockerfile Outdated Show resolved Hide resolved
src/create-envfile.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated
Comment on lines 9 to 15
## Versions

Please use this version of your action config file:

* `SpicyPizza/create-envfile@master`

* `SpicyPizza/create-envfile@v1.2`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this section makes sense. Do you mean to suggest that people should choose one of them to use?

Copy link
Contributor Author

@Flaiers Flaiers Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, this item i added to just to show the current working versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a commit to make it more verbose 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Flaiers Flaiers closed this Nov 9, 2021
@Flaiers Flaiers reopened this Nov 9, 2021
Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more item, then I'll do the commit myself with some changes 👍

Dockerfile Outdated Show resolved Hide resolved
@Flaiers
Copy link
Contributor Author

Flaiers commented Nov 9, 2021

I call you one more time to review. Everything that was discussed here was corrected. If something else, then I'm waiting feedback. Thanks!

Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes!

@AngelOnFira AngelOnFira merged commit ea2de57 into SpicyPizza:master Feb 15, 2022

jobs:

create-envfile:

runs-on: ubuntu-18.04
runs-on: ubuntu-latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't do that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care to elaborate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants