Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Rule 981244 will trigger false positives in certain common scearios #36

Closed
OrySegal opened this issue May 23, 2013 · 2 comments
Closed

Comments

@OrySegal
Copy link

The following section of the regular expression:

(?:["'´’‘]\s*?(x?or|div|like|between|and)[\w\s-]+\s*?[+<>=(),-]\s*?[\d\"'´’‘])

Will generate false positives on strings such as:

  • "orca-1"
  • 'ornament=1'
    *"divider-1"

In general, JSON objects would have a high chance of containing such strings, for example:

{"name":"divider-1"}

@rcbarnett-zz
Copy link
Contributor

Updated the regex in 2.2.8 to include word boudaries -

(?:["'´’‘]\s*?\b(x?or|div|like|between|and)\b\s*?[+<>=(),-]\s*?[\d\"'´’‘])

@OrySegal
Copy link
Author

OrySegal commented Jul 1, 2013

Thanks. I will merge this with our 2.2.6...

On 1 ביול 2013, at 19:12, Ryan Barnett notifications@github.com wrote:

Updated the regex in 2.2.8 to include word boudaries -

(?:["'´’‘]\s_?\b(x?or|div|like|between|and)\b\s_?[+<>=(),-]\s*?[\d"'´’‘])


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants