Rule 981244 will trigger false positives in certain common scearios #36

Closed
OrySegal opened this Issue May 23, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@OrySegal

The following section of the regular expression:

(?:["'´’‘]\s*?(x?or|div|like|between|and)[\w\s-]+\s*?[+<>=(),-]\s*?[\d\"'´’‘])

Will generate false positives on strings such as:

  • "orca-1"
  • 'ornament=1'
    *"divider-1"

In general, JSON objects would have a high chance of containing such strings, for example:

{"name":"divider-1"}

@rcbarnett

This comment has been minimized.

Show comment
Hide comment
@rcbarnett

rcbarnett Jul 1, 2013

Contributor

Updated the regex in 2.2.8 to include word boudaries -

(?:["'´’‘]\s*?\b(x?or|div|like|between|and)\b\s*?[+<>=(),-]\s*?[\d\"'´’‘])

Contributor

rcbarnett commented Jul 1, 2013

Updated the regex in 2.2.8 to include word boudaries -

(?:["'´’‘]\s*?\b(x?or|div|like|between|and)\b\s*?[+<>=(),-]\s*?[\d\"'´’‘])

@rcbarnett rcbarnett closed this Jul 1, 2013

@OrySegal

This comment has been minimized.

Show comment
Hide comment
@OrySegal

OrySegal Jul 1, 2013

Thanks. I will merge this with our 2.2.6...

On 1 ביול 2013, at 19:12, Ryan Barnett notifications@github.com wrote:

Updated the regex in 2.2.8 to include word boudaries -

(?:["'´’‘]\s_?\b(x?or|div|like|between|and)\b\s_?[+<>=(),-]\s*?[\d"'´’‘])


Reply to this email directly or view it on GitHub.

OrySegal commented Jul 1, 2013

Thanks. I will merge this with our 2.2.6...

On 1 ביול 2013, at 19:12, Ryan Barnett notifications@github.com wrote:

Updated the regex in 2.2.8 to include word boudaries -

(?:["'´’‘]\s_?\b(x?or|div|like|between|and)\b\s_?[+<>=(),-]\s*?[\d"'´’‘])


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment