Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS Toggle: slider here seems to have lost its vertical center #112

Closed
swanine opened this issue Apr 25, 2022 · 3 comments
Closed

FORMS Toggle: slider here seems to have lost its vertical center #112

swanine opened this issue Apr 25, 2022 · 3 comments
Labels
pending release This issue has been looked at and resolved in code. It is now pending the next release.
Projects

Comments

@swanine
Copy link

swanine commented Apr 25, 2022

Describe the bug
slider here seems to have lost its vertical center, if the design is expected to be vertically centered, is a property missing

top: 50%;
.form-ext-toggle__toggler i::after {
    background-color: $cirrus-gray;
    border-radius: 50%;
    height: 16px;
    left: 4px;
    width: 16px;
    transform: translateY(-50%);
    transition: left var(--animation-duration) ease;
    text-align: left;
}

To Reproduce
cirrus-ui.com/forms/toggle

@Spiderpig86
Copy link
Owner

Hi and thanks for reporting an issue!

Is it possible to send a screenshot to confirm what I suspect the issue is? I'm assuming you're referring to how the toggle shifts with different zoom levels.

@swanine
Copy link
Author

swanine commented Apr 28, 2022

1651110944(1)
Thank you for your reply!
On my device, I saw that the slider was not vertically centered in the container of the Toggle component

@Spiderpig86 Spiderpig86 added this to To do in 0.7.1 May 4, 2022
Spiderpig86 added a commit that referenced this issue Jun 1, 2022
@Spiderpig86
Copy link
Owner

Bug fixed with commit, closing issue.

0.7.1 automation moved this from To do to Done Jun 1, 2022
@Spiderpig86 Spiderpig86 added the pending release This issue has been looked at and resolved in code. It is now pending the next release. label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending release This issue has been looked at and resolved in code. It is now pending the next release.
Projects
0.7.1
  
Done
Development

No branches or pull requests

2 participants