Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Fix inconsistencies with col viewport classes and the rest of the framework #123

Closed
Spiderpig86 opened this issue Oct 10, 2022 · 0 comments
Closed

[BREAKING] Fix inconsistencies with col viewport classes and the rest of the framework #123

Spiderpig86 opened this issue Oct 10, 2022 · 0 comments
Assignees
@Spiderpig86
Labels
bug pending release This issue has been looked at and resolved in code. It is now pending the next release.
Projects
0.7.1

Comments

@Spiderpig86
Copy link
Owner

  • For example, col-xs-2 applies to 641px to 768px instead of 0px to 640px like the rest of the framework.
  • To fix, we need to switch to using breakpoint pairs which would effectively bump all the viewports down by 1.
  • This will be a high-impact change.
@Spiderpig86 Spiderpig86 created this issue from a note in 0.8.0 (To do) Oct 10, 2022
@Spiderpig86 Spiderpig86 self-assigned this Oct 10, 2022
@Spiderpig86 Spiderpig86 added this to To do in 0.7.1 via automation Oct 10, 2022
@Spiderpig86 Spiderpig86 removed this from To do in 0.8.0 Oct 10, 2022
@Spiderpig86 Spiderpig86 changed the title **[BREAKING] Fix inconsistencies with col viewport classes and the rest of the framework** [BREAKING] Fix inconsistencies with col viewport classes and the rest of the framework Oct 10, 2022
Spiderpig86 added a commit that referenced this issue Oct 10, 2022
@Spiderpig86
🐛 fix(layout.scss): BREAKING #123 Fix viewport classes for col shifte…
628a815 
…d up 1 viewport group than expected for 0.7.0
@Spiderpig86 Spiderpig86 moved this from To do to Done in 0.7.1 Oct 10, 2022
@Spiderpig86 Spiderpig86 added the pending release This issue has been looked at and resolved in code. It is now pending the next release. label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Spiderpig86 Spiderpig86

Labels
bug pending release This issue has been looked at and resolved in code. It is now pending the next release.
Projects
0.7.1
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Spiderpig86