Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Vertical label divider: invisible example #165

Closed
clembu opened this issue Apr 5, 2023 · 1 comment
Closed

[Documentation] Vertical label divider: invisible example #165

clembu opened this issue Apr 5, 2023 · 1 comment

Comments

@clembu
Copy link
Contributor

clembu commented Apr 5, 2023

Describe the issue with the documentation
The vertical label divider in https://www.cirrus-ui.com/layout/divider#basics is effectively invisible, but for the label itself.
Its height is either 0 or auto, because the class h-100pp is applied to it, which should be h-100p.

Issue Location (if incorrect/inconsistent information)

<div className="divider--v h-100pp" data-content="Label" />

code={`<div class="divider--v h-100pp" data-content="Label" />`}

URL: https://www.cirrus-ui.com/layout/divider#basics
Screenshots:
image

What it should say/display instead:
image

@clembu clembu changed the title Vertical label divider: invisible example [Documentation] Vertical label divider: invisible example Apr 5, 2023
clembu added a commit to clembu/Cirrus that referenced this issue Apr 5, 2023
See Spiderpig86#165 for the motivation.

Should I fix it in the other versions as well?
Spiderpig86 pushed a commit that referenced this issue Apr 7, 2023
See #165 for the motivation.

Should I fix it in the other versions as well?
@Spiderpig86
Copy link
Owner

I will be closing this issue since I merged your PR to fix it. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants