Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix margin top for input field in combination with icon, label and input-control #47

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Conversation

FlorianWoelki
Copy link
Contributor

  • Fixed a minor issue: whenever using a icon and label with input-control there was a not good looking margin-top

Description

There is an issue when putting an icon and label in combination with an input field. Because of the input-control class there will be a not good looking margin between the label and the input field. I've fixed this by adding a margin-top 0 whenever there is a label above the input-control class.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This has been tested by creating a input field with a icon and a label:

<label>Test Label</label>
<div class="input-control">
  <input type="text" class="input-contains-icon" placeholder="Test">
  <span class="icon">A</span>
</div>

Current behaviour:
image

Expected behaviour:
image

- Fixed a minor issue: whenever using a icon and label with input-control there was a not good looking margin-top
src/core/forms.scss Outdated Show resolved Hide resolved
@FlorianWoelki FlorianWoelki changed the title chore(forms.scss): Fix for input-control with use of icon and label Fix margin top for input field in combination with icon, label and input-control Nov 9, 2020
@Spiderpig86 Spiderpig86 merged commit 62cb635 into Spiderpig86:master Nov 10, 2020
@Spiderpig86
Copy link
Owner

🙌 Thanks for the fix!

@Spiderpig86 Spiderpig86 added this to Done in 0.6.1 Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.6.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants