#3665: Small improvements to TranslatableComponent

* Make TranslatableComponent format Pattern static * Fix TranslatableComponent copy constructor not copying fallback
SpigotMC · Apr 24, 2024 · 336333a · 336333a
1 parent d110f66
commit 336333a
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/chat/src/main/java/net/md_5/bungee/api/chat/TranslatableComponent.java b/chat/src/main/java/net/md_5/bungee/api/chat/TranslatableComponent.java
@@ -19,7 +19,7 @@
 public final class TranslatableComponent extends BaseComponent
 {
 
-    private final Pattern format = Pattern.compile( "%(?:(\\d+)\\$)?([A-Za-z%]|$)" );
+    private static final Pattern FORMAT = Pattern.compile( "%(?:(\\d+)\\$)?([A-Za-z%]|$)" );
 
     /**
      * The key into the Minecraft locale files to use for the translation. The
@@ -44,10 +44,11 @@ public TranslatableComponent(TranslatableComponent original)
     {
         super( original );
         setTranslate( original.getTranslate() );
+        setFallback( original.getFallback() );
 
         if ( original.getWith() != null )
         {
-            List<BaseComponent> temp = new ArrayList<BaseComponent>();
+            List<BaseComponent> temp = new ArrayList<>();
             for ( BaseComponent baseComponent : original.getWith() )
             {
                 temp.add( baseComponent.duplicate() );
@@ -177,7 +178,7 @@ private void convert(StringBuilder builder, boolean applyFormat)
             trans = fallback;
         }
 
-        Matcher matcher = format.matcher( trans );
+        Matcher matcher = FORMAT.matcher( trans );
         int position = 0;
         int i = 0;
         while ( matcher.find( position ) )