#2261: Don't send any keep alive to server if invalid

SpigotMC · Sep 23, 2017 · 8d49424 · 8d49424
1 parent 69bbc3a
commit 8d49424
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/proxy/src/main/java/net/md_5/bungee/ServerConnection.java b/proxy/src/main/java/net/md_5/bungee/ServerConnection.java
@@ -27,9 +27,6 @@ public class ServerConnection implements Server
     private final boolean forgeServer = false;
     @Getter
     @Setter
-    private boolean pingFailed;
-    @Getter
-    @Setter
     private long sentPingId = -1;
 
     private final Unsafe unsafe = new Unsafe()

diff --git a/proxy/src/main/java/net/md_5/bungee/connection/UpstreamBridge.java b/proxy/src/main/java/net/md_5/bungee/connection/UpstreamBridge.java
@@ -123,15 +123,6 @@ public void handle(KeepAlive alive) throws Exception
             con.setPing( newPing );
         } else
         {
-            if ( con.getServer().getSentPingId() != -1 && !con.getServer().isPingFailed() )
-            {
-                alive.setRandomId( con.getServer().getSentPingId() );
-                con.getServer().unsafe().sendPacket( alive );
-
-                con.getServer().setPingFailed( true );
-                con.getServer().setSentPingId( -1 );
-            }
-
             throw CancelSendSignal.INSTANCE;
         }
     }