-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make bungeecord-chat API classes final - the API does not (nor should…
…) support subclassing.
- Loading branch information
Showing
5 changed files
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dda0638
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha this broke my workaround xD
dda0638
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workaround for what?
dda0638
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.spigotmc.org/threads/componentbuilder-resets-color.288424/
My very last post. I extended ComponentBuilder to add a Method which was added in 1.12 (I must support 1.8.8 - 1.12).
Guess I will just use the normal ComponentBuilder for 1.12 versions and everything below the CustomComponentBuilder
dda0638
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen compeltely healthy code extending the ComponentBuilder to add more methods with ease. Providing more convenient methods, specialized methods, etc. through extending the ComponentBuilder seems compeltely legit for me.
dda0638
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builders are most definitely not meant to be extendable.
dda0638
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SpatiumPrinceps
If you're using an unsupported version, why would this commit affect you? If your 1.8 supporting fork would have this patch why wouldn't it have the method added in 1.12 unless you specifically excluded it?
Either way, I skimmed over your code on forum; why not just stop extending and convert into a utility class?
dda0638
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mystiflow
This commit affects me, because my users are expecting me to support all the versions (and I took the extending approach).
Already fixed it, although havent uploaded yet.
Dont get me wrong, I appreciate the work you are putting into this, md-5 :)