Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports and Guava deprecateds methods #2527

Closed
wants to merge 2 commits into from
Closed

Remove unused imports and Guava deprecateds methods #2527

wants to merge 2 commits into from

Conversation

NayXegp
Copy link
Contributor

@NayXegp NayXegp commented Sep 14, 2018

No description provided.

@NayXegp
Copy link
Contributor Author

NayXegp commented Oct 28, 2018

@md-5 I need to do some changes or something ?

@md-5
Copy link
Member

md-5 commented Oct 28, 2018

Looks ok, just doesn’t actually change anything except for adding to the history.
Will probably be merged at some point otherwise it will keep popping up (same thing did for Bukkit yesterday)

@NayXegp
Copy link
Contributor Author

NayXegp commented Oct 28, 2018

ok ty, maybe you could also look to some other pull requests
Some are open for months or years

@md-5
Copy link
Member

md-5 commented Nov 2, 2018

I'll accept this once, but please note that this is not a precedent for running automated cosmetic cleanups across the codebase.
It tends to dirty the commit history and create unnecessary merge conflicts for no real gain.

@md-5 md-5 closed this Nov 2, 2018
md-5 pushed a commit that referenced this pull request Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants