Right protocol limits for strings in the chat packet #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For version below 1.16.5 the limit is short.max_value, as 1.16.5 and 1.16.4 has the same protocol number we limit below 1.16.4 I made a plugin too printing debug stuff in the chat everything was working on 1.19.3 but on 1.8.9 i got disconnected without an exeption because the error was in the client. So i think we should apply the limit in bungee direktly
|
Looking at the source code I think the wiki is wrong |
|
But i got disconnected from the server because i received too long string you can look in the client yourself the limits in bungeecord are not correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For version below 1.16.5 the limit is short.max_value, as 1.16.5 and 1.16.4 has the same protocol number we limit below 1.16.4 I made a plugin too printing debug stuff in the chat everything was working on 1.19.3 but on 1.8.9 i got disconnected without an exeption because the error was in the client. So i think we should apply the limit in bungee directly
Edit:
https://wiki.vg/index.php?title=Protocol&oldid=16681#Chat_Message_.28clientbound.29 1.16.5 262144
https://wiki.vg/index.php?title=Protocol&oldid=16317#Chat_Message_.28clientbound.29 1.16.4 32767
1.8 32767