Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for custom notification sounds #122

Closed
cozykitten opened this issue Oct 21, 2023 · 2 comments
Closed

[Feature Request] Support for custom notification sounds #122

cozykitten opened this issue Oct 21, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@cozykitten
Copy link

...or support for BD plugins since BD has one that does that.
Though that plugin encodes the full notification sounds as base64 string, probably not ideal performance wise?

Describe the solution you'd like
Support for custom notification sounds in Dorion itself would be amazing.
Perhaps the alternative discord notification sounds could somehow be unlocked so they wouldnt have to be added as custom sounds?

Describe alternatives you've considered
Supporting BD plugins would allow the use of the custom notification sounds plugin.

Additional context
For reference
image
image

@cozykitten cozykitten added the enhancement New feature or request label Oct 21, 2023
@SpikeHD
Copy link
Owner

SpikeHD commented Oct 22, 2023

Currently being worked on here, and will support both links and local sound files.

Though that plugin encodes the full notification sounds as base64 string, probably not ideal performance wise?

Going off of memory I believe they are cached by the browser in the same way as remote resources so it shouldn't be an issue other than them taking up slightly more disk space.

@SpikeHD
Copy link
Owner

SpikeHD commented Nov 3, 2023

I'm gonna close this since I can't find a good way to do it with Shelter, and since Vencord will have the plugin eventually (and Vencord is still supported in Dorion), it'll be out of my direct control anyways.

@SpikeHD SpikeHD closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants