CustomSounds

[TheKodeToad]

Open

• in case I die
• so you can criticise my bad code

Roadmap

what does Roadmap mean? I'm sure it's not important

To-do / Issues

• Upload local file (how should I store the data) fixed
• Settings are applied directly instead of being queued won't fix
• Setting initialisation is lazy which is weird fixed
• More sound customisation won't fix in this PR
• Additional sounds for specific conditions or events not normally covered won't fix in this PR
• Get it to play nicely with Discord's built in sound themes option fixed

[SpikeHD]

@TheKodeToad couple questions about direction:

Upload local file (how should I store the data)

I made it just do the classic "upload and convert/save to data URI" which I think is probably the best option, lemme know if anyone thinks of anything better.

Settings are applied directly instead of being queued

I don't really see this as a problem, only issue being that the "Save" part of the "Save & close" button is technically a bit misleading. I feel like it would take more effort to write the settings queuing than to just leave it as-is, are you opposed at all to just leaving it?

More sound customisation/Additional sounds for specific conditions or events not normally covered

Curious what you mean and whether these can just be saved as something to do after the initial plugin is done. From what I've observed, the majority of users just want to change basic sounds like the ringing and notification noise, and it'd be nice to just get it out there first and expand later!

Get it to play nicely with Discord's built in sound themes option

Honestly didn't even know this was a thing and I can't find anything about it. Is it a Nitro thing or am I blind, and is there a known problem with it/way to test?

Also planning on adding a button to upload "sound packs" (simple JSON files describe sounds overrides) for people to share... well... sound packs. Let me know if that idea sucks 😛

[TheKodeToad]

Enable the April Fools' 2023 experiment to see them in settings.
that's what the detune was for

[TheKodeToad]

I made it just do the classic "upload and convert/save to data URI" which I think is probably the best option, lemme know if anyone thinks of anything better.

There's a reason I wasn't sure on the best way to store the data. I think IndexedDB would be better... maybe I could just move all settings there like TextReplace but I thought having the URLs was okay in the settings JSON

[TheKodeToad]

but thanks lol

[SpikeHD]

I can see about moving the settings to IndexedDB tmr if I find time/don't forget. As for the other sounds (eg. detune sounds), I can probably just load them on-the-fly like how I did in my PR, that way it always works between additions/removals of sounds. That means they won't show up in the settings menu unless the plugin is enabled though, which admittedly is a little strange. Or that stuff, too, could just be left until after the initial plugin is finished, but that's not up to me 😄 .

[TheKodeToad]

I might be able to figure it out, but my idea was to - if a sound is enabled - use the default sound instead of the soundpacks'

[KateReller]

Mod broke with the major Discord update that broke Vencord

[thereal-marr]

Plugin borked because of the latest discord update

[thereal-marr]

interestingly, now vesktop crashes when I try to open customsounds settings

[KateReller]

interestingly, now vesktop crashes when I try to open customsounds settings

It has to do with the names of the authors. I just removed the second name in index.tsx on line 54 and it stops.

[thereal-marr]

It has to do with the names of the authors. I just removed the second name in index.tsx on line 54 and it stops.

sounds good! i notice the custom sounds themselves actually work fine and its just the settings that won't open lol so this is a good fix

[Impeta]

Anything else stopping it from getting merged?

[TheKodeToad]

Looks like I messed something up and the type checker is failing

[Baldi89989]

Settings crash because of the authors, i removed the authors and it works fine. (i checked the console and there was errors with the name).

[Person7557]

Hello. I'm lost, but it seems like you guys made it happen, so, some directions how i can download this so i can finally adjust all the sounds in vencord, thanks.