Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure when added as a dependency #67

Open
dingxiangfei2009 opened this issue May 17, 2018 · 2 comments
Open

Build failure when added as a dependency #67

dingxiangfei2009 opened this issue May 17, 2018 · 2 comments

Comments

@dingxiangfei2009
Copy link

Since protobuf has removed MessageStatic in version 1.6.0, including rusty_secrets as a dependency in Cargo.toml now leads to build failure.

To reproduce this, create a new Rust project with cargo new, add the dependency rusty_secrets = "0.2.1" and build this project with cargo build.
This happens even though protobuf version is pinned to 1.5.1 in the Cargo.lock file.

@romac
Copy link
Member

romac commented May 17, 2018

Ouch, sorry about that, and thanks for the report!

I have just released version 0.2.2 which restricts protobuf to >=1.4 and <1.6, which should fix the issue for now. I will release version 0.3.0 in the next few days, which will come with protobuf 1.6.

Let me know if that works for you

@dingxiangfei2009
Copy link
Author

I have a small idea. Maybe we can use protoc_rust to trans-compile .proto schemata into Rust sources inside the build.rs file, so that they are re-generated every time it is compiled.

Let me prepare a pull request. You may see whether this approach is suitable. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants