Swap order of actual and expected value args in super class verify_xxx functions #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=======================================
Coverage 26.40% 26.40%
=======================================
Files 235 235
Lines 15690 15690
=======================================
Hits 4143 4143
Misses 11547 11547 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
RichardWaiteSTFC
changed the base branch from
master
to
72_test_spinw_genmagstr
RichardWaiteSTFC
changed the base branch from
72_test_spinw_genmagstr
to
master
This is to be consistent with the order of the arguments in the MATLAB testCase assertion funcs
Arguments to verify_val were already in required order (actual, expected)
RichardWaiteSTFC
force-pushed
the
101_swap_order_args_in_super_class_verify_obj_funcs
branch
from
4e22efb
to
cf37f9a
Compare
mducle
deleted the
101_swap_order_args_in_super_class_verify_obj_funcs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap order of actual and expected value args in super class verify_xxx functions to be consistent with the MATLAb testCase verify functions.
Fixes #101