-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tests #138
Improve tests #138
Conversation
Zero initialises arrays in chol_omp seems to fix remaining flaky mex tests Change omp critical to atomic for better performance
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
- Coverage 38.98% 38.67% -0.31%
==========================================
Files 239 239
Lines 15829 15829
==========================================
- Hits 6171 6122 -49
- Misses 9658 9707 +49
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks!
Reduces the verbosity of the tests by setting
fid
to0
to suppress output and removing a lot of warnings.Also:
rotc
matrix definition compared to the reference data. Currently this is "fixed" by forcing the test to use the old twin matrix.chol_omp
mex file.optmagk
to avoid occasional test failures as it converges to a local minimum.persistent
forswpref
insw_timeit
to avoid performance hit