Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image display correct #29

Merged
merged 2 commits into from Jan 11, 2020
Merged

image display correct #29

merged 2 commits into from Jan 11, 2020

Conversation

jijingg
Copy link
Collaborator

@jijingg jijingg commented Jan 10, 2020

@wifasoi sorry the PR #19 pictures are not displayed correctly, updated again.

@wifasoi wifasoi merged commit 21e1943 into SpinalHDL:master Jan 11, 2020
@wifasoi
Copy link
Collaborator

wifasoi commented Jan 11, 2020

Didn't catch it in my review, thank you for the fix :)

@jijingg
Copy link
Collaborator Author

jijingg commented Jan 12, 2020

@wifasoi oh no, sorry again, the image still display incorrect. 😰 can you help me modify
/asset/imag/fixpoint/... to
/asset/image/fixpoint/...
there have 3 place in https://github.com/SpinalHDL/SpinalDoc-RTD/blob/master/source/SpinalHDL/Data%20types/Int.rst

Murphy's law at work ,without verification , there must have wrong. 😅
i found it's necessary to install pyenv and have HTML display review before submitting a PR.

@wifasoi
Copy link
Collaborator

wifasoi commented Jan 12, 2020

The one time I lazy out this assignment (just a visual inspection, didn't compile manually) and you betrayed me! :P
BTW: No hard feeling, I'll fix it later for you.
Still thank you for documenting your work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants