Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AxiLite4: Add read only and write only driver classes #1007

Merged
merged 1 commit into from
Jan 9, 2023
Merged

AxiLite4: Add read only and write only driver classes #1007

merged 1 commit into from
Jan 9, 2023

Conversation

kleinai
Copy link
Collaborator

@kleinai kleinai commented Jan 5, 2023

Context, Motivation & Description

Add drivers for AxiLite4 read only and write only channels. These are designed to replicate some of the features the Axi4 sim drivers have. This supports future Axi to AxiLite4 tests.

Impact on code generation

Checklist

  • Unit tests were added
  • API changes are or will be documented:

@Readon
Copy link
Collaborator

Readon commented Jan 8, 2023

Sorry, I am not that familiar with GitHub's operation, and wrongly edited the file directly.

@numero-744 would you please give some tips on how to create the modification suggestion by reviewer, so that authors can determine if they can accept the changes easily by clicking the button.

@numero-744
Copy link
Collaborator

@Readon

  • Click "files changed" tab
  • Click the line number you want to comment, it becomes yellow
  • If needed, Shift+click another one to select a range, which becomes yellow
  • Click the white-on-blue + button of the last line of the selected range
  • Then there is a line with "Write", "Preview", then a blank, then the formatting buttons. The first one is a file with a + and a - on it. Click it
  • It adds a snippet ```suggestion in your comment with the selected code inside. You can then just edit this snippet in your comment, and the diff will be processed on Preview (line diff) and after submission of the comment (line + word diff).

@Readon
Copy link
Collaborator

Readon commented Jan 8, 2023

@Readon

  • Click "files changed" tab
  • Click the line number you want to comment, it becomes yellow
  • If needed, Shift+click another one to select a range, which becomes yellow
  • Click the white-on-blue + button of the last line of the selected range
  • Then there is a line with "Write", "Preview", then a blank, then the formatting buttons. The first one is a file with a + and a - on it. Click it
  • It adds a snippet ```suggestion in your comment with the selected code inside. You can then just edit this snippet in your comment, and the diff will be processed on Preview (line diff) and after submission of the comment (line + word diff).

Thanks, that would be useful.

@Readon
Copy link
Collaborator

Readon commented Jan 8, 2023

At the same time, I understand that the simulation code could not call the setOKAY directly.

@numero-744
Copy link
Collaborator

Cause not an HLS ^^' @Readon can I try to clean the branch by removing your 2 commits?

@Readon
Copy link
Collaborator

Readon commented Jan 8, 2023

Cause not an HLS ^^' @Readon can I try to clean the branch by removing your 2 commits?

Sure, thanks.

@numero-744
Copy link
Collaborator

@Readon Nothing happened XD

@kleinai
Copy link
Collaborator Author

kleinai commented Jan 8, 2023

At the same time, I understand that the simulation code could not call the setOKAY directly.

Yes I don't believe that function can be used to drive the simulation signals as it's a hardware assignment.

@Readon
Copy link
Collaborator

Readon commented Jan 8, 2023

At the same time, I understand that the simulation code could not call the setOKAY directly.

Yes I don't believe that function can be used to drive the simulation signals as it's a hardware assignment.

I just always concerns on the constant values.

@kleinai
Copy link
Collaborator Author

kleinai commented Jan 8, 2023

At the same time, I understand that the simulation code could not call the setOKAY directly.

Yes I don't believe that function can be used to drive the simulation signals as it's a hardware assignment.

I just always concerns on the constant values.

I could define them in the file if that looks better.

@numero-744
Copy link
Collaborator

@Readon I think you meant discussing using literal values when constants can be used instead, in this case I aggree.

Maybe the simulation equivalent for hardware functions should be implemented? This was one of the goals of withEnv in #968 and of #879

@Readon
Copy link
Collaborator

Readon commented Jan 8, 2023

I could define them in the file if that looks better.

It's not necessary to do that now, there are still lots of code with constant value.

@Readon Readon merged commit 8b41217 into SpinalHDL:dev Jan 9, 2023
Dolu1990 pushed a commit that referenced this pull request Feb 9, 2023
AxiLite4: Add read only and write only driver classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants