Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix OS version to ubuntu20 and revert to build iverilog into cache. #1009

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

Readon
Copy link
Collaborator

@Readon Readon commented Jan 10, 2023

Closes #

Context, Motivation & Description

To make sure the current CI working and fill the time gap to @numero-744 's new CI.
Temporarily fix OS version to ubuntu20 and revert to build iverilog into cache.

Impact on code generation

Checklist

  • Unit tests were added
  • API changes are or will be documented:

@Readon
Copy link
Collaborator Author

Readon commented Jan 10, 2023

@numero-744 If the new CI is not going to be work very soon, I suggest to fall back to previous one first.

@numero-744
Copy link
Collaborator

I just have to fix an issue with cocotb, I'll fix it when I have time

@Readon
Copy link
Collaborator Author

Readon commented Jan 10, 2023

I just have to fix an issue with cocotb, I'll fix it when I have time

I think the current CI cache can work, it's not necessary to merge this temporarily.

@Readon
Copy link
Collaborator Author

Readon commented Jan 10, 2023

have to fix an issue with cocotb, I'll fix it when I have time

I just have to fix an issue with cocotb, I'll fix it when I have time

Ok, I will merge this first due to #994 is still fail while testing.

@Readon Readon merged commit 5c62141 into SpinalHDL:dev Jan 10, 2023
@numero-744
Copy link
Collaborator

It seems this PR, by reverting a workaround, unsurprisingly re-introduced the issue the workaround was fixing, aka:

 parse.cc:140:10: fatal error: parse.hh: No such file or directory
...
 /home/runner/.local/lib/python3.10/site-packages/cocotb/share/makefiles/simulators/Makefile.icarus:53: *** Unable to locate command >iverilog<.  Stop.

Except when caching makes it look like it works

Dolu1990 pushed a commit that referenced this pull request Feb 9, 2023
fix: fix OS version to ubuntu20 and revert to build iverilog into cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants