Fix subdivideIn(..., n bit) for corner cases #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When splitting 8 into 5 the old algorithm would generate an inconsistent result with other cases as it would generate two slices of 4 bit. In most other cases subdivideIn would generate the expected width as long as possible, and have a smaller last element.
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When splitting 8 into 5 the old algorithm would generate an inconsistent result with other cases as it would generate two slices of 4 bit. In most other cases subdivideIn would generate the expected width as long as possible, and have a smaller last element.
If this is actually expected behavior I'd update the documentation to mention it.
Closes #1049
Impact on code generation
None
Checklist