PhysicalUnit formatting #1075
Merged
PhysicalUnit formatting #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
<3 |
|
Fell free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make both HertzNumber and TimeNumber consistent that both have
decompose/decomposeString(missing on HertzNumber before). Also make both formattable via f-interpolation,String.format, etc.Context, Motivation & Description
Simpler use when printing/reporting/building error messages.
Impact on code generation
No impact on code generation, but code that printed the classes w/o any formatting will now generate different output. This should not be an issue though because the format was unspecific and not well specified before.
Checklist