Add setAll() and clearAll() for Data #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekPikula
force-pushed
the
data_clearall
branch
from
75d5e81
to
0d48987
Compare
Dolu1990
reviewed
Apr 8, 2023
| @@ -422,6 +422,15 @@ trait Data extends ContextUser with NameableByComponent with Assignable with Spi | |||
| def assignFromBits(bits: Bits, hi: Int, low: Int): Unit | |||
| def assignFromBits(bits: Bits, offset: Int, bitCount: BitCount): Unit = this.assignFromBits(bits, offset + bitCount.value - 1, offset) | |||
|
|
|||
| def clearAll(): this.type = { | |||
There was a problem hiding this comment.
I think it would be great to provide clearAll setAll implementation to the Bool class too, to reduce the number of nodes in the netlist :)
There was a problem hiding this comment.
Sorry, I somehow missed your comment in my inbox. Pushed the commit addressing Bool.
Signed-off-by: Marek Pikuła <marek@serenitycode.dev>
Signed-off-by: Marek Pikuła <marek@serenitycode.dev>
To reduce the number of nodes in the netlist. Signed-off-by: Marek Pikuła <marek@serenitycode.dev>
MarekPikula
force-pushed
the
data_clearall
branch
from
0d48987
to
da57651
Compare
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context, Motivation & Description
Sometimes I need to zero out an entire bundle, but assigning each bundle signal is tedious, especially for multi-level Bundles. I ended up using the method in the PR as it's simple and uses some of the most basic methods available (even for Data), so I figured that it could be added directly to
Data. Let me know if that's the place for this sort of general method, or should it be higher up in the hard type hierarchy?Also, I noticed that this pattern is often used in RegIf, so I changed it as well to use the new construct from Data.
Impact on code generation
None, convenience function for
Data, which is already implemented forBitVectorand some of its children.Checklist
/** */?