-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial docker image build file which support dev. #1085
Conversation
The size of images has been reduced by 1 GB now. All compiled executables are put in /opt directory. Personally, I recommend use podman to avoid the file permission problems. |
I just tried the container on:
What I could not try is in an airgapped environment as you are currently not copying the caches to the container. It did not work on our company CI due to access rights (it forces a random user). I had a look at the Dockerfile that I build a while ago for that, and there I set the environment such that regardless of user the same sbt/cache directories are used via adding this before installing anything sbt related:
This way all users will use the same directory for cache, etc. and since the GID is 0 it works out. One other question: is there a reason why you install Java11 instead of the current LTS (17) (11 is the LTS from 2018) |
Good work!
I am also struggling with the problems that might meet in airgapped environment.
This is a good idea to avoid installing related packages for each user.
Emm, I am really not an expert of Java, so that I only tried Java8 and found that its package on Ubuntu depends on X11 related packages which make the disk occupation large. Then Java11 is adopted. |
To get my images to work w/o internet connectivity I had to actually run There is no significant feature other than speed improvements made over ~3 years when you go to |
I am currently rethinking the design purpose of docker images. There is no need to release an image for each version if we just want to build a compile and test environment for spinalhdl itself. A fixed version of the image should be sufficient. I have created a PR in SpinalHDL/docker#6 which can create a docker image with sufficient tools. If we want to provide a base image for custom projects, then it makes sense to release for each version. |
e7bfaf5
to
8a5d549
Compare
I close this temporarily, the dev branch is frequently changed during test, it would not be a good practice to run test on it every time. |
FYI this is what I do at work (because our CI machines to not have internet access) - I run my project once to fill the caches and then continue to use that image as long as possible ;-) |
Context, Motivation & Description
Impact on code generation
Checklist
- [ ] Unit tests were added- [ ] API changes are or will be documented:/** */
?