Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spinal.lib.bus.fabric reusable base classes #1160

Merged
merged 18 commits into from
Jul 28, 2023
Merged

spinal.lib.bus.fabric reusable base classes #1160

merged 18 commits into from
Jul 28, 2023

Conversation

Dolu1990
Copy link
Member

Another attempts of #1156
WIP

@Dolu1990 Dolu1990 mentioned this pull request Jul 12, 2023
Closed
2 tasks
@kleinai
Copy link
Collaborator

kleinai commented Jul 12, 2023

There's a whole thread in TileLink node that's not implemented in bus.fabric. Is that assumed to be implementation specific?

@Dolu1990
Copy link
Member Author

There's a whole thread in TileLink node that's not implemented in bus.fabric. Is that assumed to be implementation specific?

Yes, the idea is to keep it for the final class.

Also, note that for AXI, there will be no s2m, only m2s.

@kleinai
Copy link
Collaborator

kleinai commented Jul 12, 2023

Yes, the idea is to keep it for the final class.

Also, note that for AXI, there will be no s2m, only m2s.

Ah okay. If you're happy with this code lets merge it!

@Dolu1990 Dolu1990 changed the base branch from dev to tilelink July 12, 2023 21:17
@Dolu1990 Dolu1990 changed the base branch from tilelink to dev July 12, 2023 21:23
kleinai
kleinai reviewed Jul 12, 2023
View reviewed changes
lib/src/main/scala/spinal/lib/bus/fabric/NegociateSP.scala Outdated
/**
* Negotiation handles for master to slave requests
*/
abstract class NegociateSP[S, P] extends Area{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick fix: this should be NegotiateSP

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure :D

@Dolu1990
Copy link
Member Author

I guess the dev can continue in the bus-fabric branch

@kleinai Were you thinking about implementing a AXI version ?

@kleinai
Copy link
Collaborator

kleinai commented Jul 14, 2023

I guess the dev can continue in the bus-fabric branch

@kleinai Were you thinking about implementing a AXI version ?

That was the plan to test out the new changes.

@Dolu1990
Copy link
Member Author

I guess the dev can continue in the bus-fabric branch
@kleinai Were you thinking about implementing a AXI version ?

That was the plan to test out the new changes.

Cool ^^
Maybe we should do a call then :)

@Dolu1990 Dolu1990 merged commit 5678e44 into dev Jul 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleinai kleinai kleinai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dolu1990 @kleinai