Added explicit net types to verilog ports #1228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1225
Context, Motivation & Description
Adds explicit net types to the top level ports of Verilog modules. Specifying the net type will keep some vendor synthesis flows from failing or giving warnings.
Example:
ERROR: net type must be explicitly specified for 'io_sdClk' when default_nettype is none (VERI-1906)
In addition to the above since the net type is not specified or is "none" it is susceptible to being changed if the user has set `default_nettype elsewhere in the project.
Notes:
Did not add unit test because the change is small. I did run all existing sbt tests to ensure everything still passes.
Impact on code generation
Impacts Verilog code generation.
Generated Verilog file WishboneSimpleSlave.v as an example.
Before change:
After change:
Checklist
/** */
?