PackedBundle Bug Fix #1271
Merged
PackedBundle Bug Fix #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MappingBuilder was not allocating the correct next range for untagged Data element, causing low bit overlaps.
Added `pack mixed spec` and `unpack mixed spec` tests that target PackedBundles with mixed spec: those that use `packFrom`, `packTo` along with non-tagged Data. Cleaned up extra debug lines. Removed `withWave` from all sims.
|
Thanks ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1204
Context, Motivation & Description
Fixed PackedBundle bit overlap when using multiple
Datas without using an explicit specifier (e.g.,packToorpackFrom).Other changes:
withWavefrom sims.Impact on code generation
None
Checklist
/** */?