validate component and declaration naming #1468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #1463
Context, Motivation & Description
Spinal now checks the names of components and declarations for validity in the currently active language.
If an invalid name is found, it fails the generation.
If an invalid name in another than the currently active language is found, it reports a warning.
Impact on code generation
Spinal will now refuse to generate code that has invalid identifiers. Previously Spinal did just generate it and at a later step the user had to find out (through GHDL, Quartus, etc.) that the generated code was invalid.
Checklist
API changes are or will be documented:-> no changes to API