Make APB3CCToggle sensitive to PSEL #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distributed
changed the title
|
Version.sc and Version.scala changes need to be reverted ^^ |
Previously, Apb3CCToggle was reacting to outside transactions. When a subsequent transaction through the CDC happened at the wrong time, the CDC would be seen answering with data from a misinterpreted previous outside transaction.
distributed
force-pushed
the
apb3-cc-toggle-psel-sensitive
branch
from
fe39625
to
ab91c0e
Compare
|
I.e. rebase to |
|
Yes ^^ Thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context, Motivation & Description
Apb3CCToggledoes not consider thePSELsignal. The internal state machine is activated by bus traffic for other slaves. Under the right timing conditions this can lead to the input side of the CDC replying to transactions too early, giving wrong read data.The fix is to make
Apb3CCTogglelook at thePSELsignal before performing work.Impact on code generation
None, except for slightly changed component logic.
Checklist
/** */?