-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add comparison operators to PhysicalNumber #997
feat: add comparison operators to PhysicalNumber #997
Conversation
I think we can merge this without issue if it passes tests. |
3c87b58
to
fbb6b78
Compare
I'm going to fix the offending sim code because I wrote it two different ways and I prefer the match-case way instead of the not equal check. |
fbb6b78
to
303ad16
Compare
303ad16
to
83c6505
Compare
So... with this implementation |
How do you think it should be documented? (Do you think it should be?) |
I don´t think we need specific documentation, |
Context, Motivation & Description
In code for checking frequencies/times are in range, e.g. for calculating&checking PLL parameters it's much more readable when PhysicalNumbers can be compared directly and with units, instead of having to go through
toBigDecimal
.Impact on code generation
None
Checklist
/** */
?