BlackBoxBoundedContext improvements #1146
Conversation
…java into bbbc-improvements # Conflicts: # license-report.md
# Conflicts: # license-report.md
|
@armiol, PTAL. |
| AggUserNotified.class)) | ||
| .close(); | ||
| EventSubject assertEvents = context.receivesCommand(reassignTask()) | ||
| .assertEvents(); |
There was a problem hiding this comment.
Looks the alignment is broken here.
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This line looks redundant to me.
|
|
||
| MESSAGE_COUNT("the count of the generated messages is"), | ||
| REQUESTED_INDEX("but the requested index was"), | ||
| @SuppressWarnings("DuplicateStringLiteralInspection") |
There was a problem hiding this comment.
Please comment on this. Just for consistency.
| if (index >= size) { | ||
| public final ProtoSubject message(int index) { | ||
| if (messages() == null) { | ||
| failWithActual(fact(FactKey.ACTUAL.value, null)); |
There was a problem hiding this comment.
Can we use the enum values without referencing the enum name?
| T outerObject = Iterables.get(messages(), index); | ||
| Message unpacked = AnyPacker.unpack(outerObject.getMessage()); | ||
| return ProtoTruth.assertThat(unpacked); | ||
|
|
| * | ||
| * @return an immutable copy of the {@code actual} messages | ||
| */ | ||
| public List<T> actual() { |
There was a problem hiding this comment.
I am not sure, but we tend to use the returning values of such methods as plain Lists and then eventually wrap them into ImmutableLists over and over again.
So if we can declare the ImmutableList as a type of the returning value, I would do so.
Codecov Report
@@ Coverage Diff @@
## master #1146 +/- ##
=========================================
Coverage ? 91.72%
Complexity ? 4094
=========================================
Files ? 536
Lines ? 12968
Branches ? 748
=========================================
Hits ? 11895
Misses ? 839
Partials ? 234 |
|
@armiol, PTAL again. |
|
@dmdashenkov @dmitrykuzmin please settle down on the conflicts. We need |
# Conflicts: # license-report.md
In this PR we provide a number of enhancements for the
BlackBoxBoundedContextAPI:Subjects now expose theactual()method in order to allow users to build more complex verifications, for example, to test metadata of dispatched signals.