[1.x] Make IntegrationBroker safer. Adjust SubscriptionService for standalone event producers.
#1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. standalone handlers and reactors).
…er all standalone producers in the `Stand` corresponding to their Bounded Contexts.
Rename the test method.
armiol
changed the title
IntegrationBroker safer. Adjust SubscriptionService for standalone event producers.IntegrationBroker safer. Adjust SubscriptionService for standalone event producers.
dmdashenkov
approved these changes
Nov 23, 2021
Codecov Report
@@ Coverage Diff @@
## 1.x-dev #1423 +/- ##
=============================================
- Coverage 91.00% 91.00% -0.01%
- Complexity 4807 4811 +4
=============================================
Files 616 616
Lines 15282 15294 +12
Branches 864 864
=============================================
+ Hits 13908 13918 +10
- Misses 1101 1103 +2
Partials 273 273 |
This was referenced Nov 23, 2021
[2.x] Make
IntegrationBroker safer. Adjust SubscriptionService for standalone event producers.
#1424
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset addresses #1349 and #1370.
In particular, the internals of
IntegrationBrokerwere made more thread-safe.Also,
SubscriptionServicenow properly locates the Bounded Context when subscribing to events produced by standalone producers, such asAbstractCommandHandlerorAbstractEventReactordescendants. Previously, these dispatchers did not register themselves inStand. Therefore,SubscriptionServicewas failing to find the target Bounded Context and always ended up creating a number of redundant event subscriptions in each known Bounded Context.