Don't add state query param twice

[passsy]

I was wondering why the direction argument wasn't working for github.pullRequests.list(). Turns out a double ? was added in the URI.

[timmaffett]

I am new to this library, but in evaluating the code and the repository activity I found it interesting that this PR has not been merged into the code yet.. This is clearly a bug, and this is clearly a correct fix:

Stream<PullRequest> list(
    RepositorySlug slug, {
    int? pages,
    String? base,
    String direction = 'desc',
    String? head,
    String sort = 'created',
    String state = 'open',
  }) {
    final params = <String, dynamic>{};
    putValue('base', base, params);
    putValue('direction', direction, params);
    putValue('head', head, params);
    putValue('sort', sort, params);
    putValue('state', state, params);   ///<<ALWAYS added to params here, so it will get included

    return PaginationHelper(github).objects(
        'GET',
        '/repos/${slug.fullName}/pulls?state=$state',  //<< and this '?state=$state' at end will always result in bad url 
                                                                                 //<<when query params are subsequently added in GitHub.request()
        (dynamic i) => PullRequest.fromJson(i),
        pages: pages,
        params: params);
  }

• The state is always added to the query params (putValue('state', state, params);)
• The params object is always passed to the PaginationHelper()
• and that URL of '/repos/${slug.fullName}/pulls?state=$state' , with the '?state=$state' appended onto the end, will always result in an incorrect URL when the param object eventually passed to GitHub.request() and the params is used to build a query string and it is appended to the path...

[passsy]

@robbecker-wf, @CaseyHillers?

[robbecker-wf]

Released in https://github.com/SpinlockLabs/github.dart/releases/tag/9.1.1