Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to allow different merge methods in pulls_service #333

Merged
merged 3 commits into from Oct 31, 2022

Conversation

ricardoamador
Copy link
Collaborator

Updating the merge pull request service to allow the merge method to be specified when merging a pull request.
Also allowing the sha to be specified and adding the recommended headers (by github) when making the request to the service.

@ricardoamador
Copy link
Collaborator Author

@robrbecker can you take a look at this por favor?

@CaseyHillers CaseyHillers added the semver:minor Non-Breaking Public API Changes (additions) label Oct 26, 2022
Copy link
Member

@robrbecker robrbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulls_test passes

@robrbecker
Copy link
Member

Sorry I didn't get to this sooner. Are you happy with it too @CaseyHillers? Ready for me to merge?

@robrbecker
Copy link
Member

FYI It LGTM so if I don't hear from you today, I'm just going to merge and release it.

@robrbecker robrbecker merged commit 6854f40 into SpinlockLabs:master Oct 31, 2022
@robbecker-wf
Copy link
Contributor

Released in version 9.6.0 https://github.com/SpinlockLabs/github.dart/releases/tag/9.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released semver:minor Non-Breaking Public API Changes (additions)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants