Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "head_branch" field to CheckSuite object #347

Merged
merged 4 commits into from Jan 26, 2023

Conversation

nehalvpatel
Copy link
Contributor

This field is part of the "check_suite" object as seen here: https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads?actionType=rerequested#check_run

Although the head_sha usually provides enough information, it is useful to know which branch was targeted when the checkrun was rerequested.

Image Screenshot 2023-01-17 at 3 51 33 PM

ricardoamador
ricardoamador previously approved these changes Jan 18, 2023
Copy link
Collaborator

@ricardoamador ricardoamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ricardoamador
Copy link
Collaborator

@robrbecker Can you please take a look at this?

@CaseyHillers CaseyHillers self-requested a review January 24, 2023 04:16
@CaseyHillers CaseyHillers added semver:minor Non-Breaking Public API Changes (additions) unreleased labels Jan 24, 2023
Copy link
Collaborator

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one operational request before we can release this

@@ -362,12 +362,14 @@ class CheckRunAction {
@immutable
class CheckSuite {
final int? id;
final String? headBranch;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the changelog and pubspec?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! I wasn't sure about the version to use so lmk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released semver:minor Non-Breaking Public API Changes (additions)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants