Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose IssueLabel.description; update labels REST APIs #355

Merged
merged 4 commits into from Mar 15, 2023

Conversation

devoncarew
Copy link
Contributor

  • expose the IssueLabel description field
  • pass a description param to createLabel
  • rename editLabel to updateLabel to match the github API; update the implementation to use PATCH, and update the available params (new_name, color, description) to match the API

@devoncarew
Copy link
Contributor Author

(ptal, updated)

@devoncarew
Copy link
Contributor Author

@robrbecker - can you take another look at this PR? We have a tool which normalizes the labels used across the dart-lang repos (https://github.com/dart-lang/ecosystem/tree/main/pkgs/repo_manage), but it does require this fix:) I believe that the PR as written is a 'new api' change (9.10.1 ==> 9.11.x), rather than a major version bump.

@robrbecker robrbecker added the semver:minor Non-Breaking Public API Changes (additions) label Mar 15, 2023
@robrbecker robrbecker merged commit 1586738 into SpinlockLabs:master Mar 15, 2023
@robbecker-wf
Copy link
Contributor

robbecker-wf commented Mar 15, 2023

Released in version 9.11.0 https://github.com/SpinlockLabs/github.dart/releases/tag/9.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released semver:minor Non-Breaking Public API Changes (additions)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants