Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dart CI; update action versions #358

Merged
merged 1 commit into from
Mar 13, 2023
Merged

update dart CI; update action versions #358

merged 1 commit into from
Mar 13, 2023

Conversation

devoncarew
Copy link
Contributor

  • update action versions to the latest major versions
  • add a dependabot config entry to rev actions versions going forward
  • consolidate the test.yml workflow and the dart.yml one into one file and update the config a bit

I noticed that some of the action versions were pretty old, and having two different workflows for dart checks didn't seem intentional? Happy to revert parts of this PR if desired.

@robrbecker robrbecker added semver:patch Bug fixes, no public API changes unreleased labels Mar 13, 2023
robrbecker
robrbecker approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@robrbecker robrbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the maintenance update! This looks great. Consolidating the test runs and other checks means the tests won't run in parallel to the other checks, but everything runs in about 45s so, that's not a big deal to me.

@robrbecker
Copy link
Member

QA+1 : Dart checks pass
(the label adding github action is failing currently but is unrelated to this PR)
merging ...

@robrbecker robrbecker merged commit 3206fbe into SpinlockLabs:master Mar 13, 2023
@robbecker-wf
Copy link
Contributor

Released in version 9.8.0 https://github.com/SpinlockLabs/github.dart/releases/tag/9.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrbecker robrbecker robrbecker approved these changes

Assignees
No one assigned
Labels
released semver:patch Bug fixes, no public API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devoncarew @robrbecker @robbecker-wf