Skip to content

Conversation

CaseyHillers
Copy link
Collaborator

For the most part, this is already non-nullable.

See flutter/flutter#129134 - This should help with debugging why our server is getting a null auth state.

@CaseyHillers CaseyHillers added the semver:minor Non-Breaking Public API Changes (additions) label Jun 20, 2023
@kevmoo
Copy link
Collaborator

kevmoo commented Jun 20, 2023

We'll want a changelog entry here, right?

@CaseyHillers
Copy link
Collaborator Author

We'll want a changelog entry here, right?

Changelog entries are generated by the GitHub action

@kevmoo kevmoo merged commit c07c634 into SpinlockLabs:master Jun 20, 2023
@CaseyHillers
Copy link
Collaborator Author

@robbecker-wf can you help release this? \cc @ricardoamador

@robrbecker
Copy link
Member

Released in version 9.15.0 https://github.com/SpinlockLabs/github.dart/releases/tag/9.15.0

@Hixie
Copy link
Contributor

Hixie commented Jun 23, 2023

I don't mind making this non-nullable, but can we restore making it mutable? GitHub credentials regularly need to be refreshed and having to recreate a whole new GitHub object each time is more annoying that just giving the existing object a new authentication token.

@CaseyHillers
Copy link
Collaborator Author

I don't mind making this non-nullable, but can we restore making it mutable?

Out of curiosity, do you have sample code I could take a look at? This seems like a fair request, but I was under the impression most callers will recreate the entire client instead of re-minting the auth.

@Hixie
Copy link
Contributor

Hixie commented Jun 26, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor Non-Breaking Public API Changes (additions)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants