Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue parsing DPDK arguments that have multiple parameters from the CLI #248

Open
dmortondev opened this issue Jun 8, 2020 · 0 comments
Open

Issue parsing DPDK arguments that have multiple parameters from the CLI #248

dmortondev opened this issue Jun 8, 2020 · 0 comments

Comments

@dmortondev
Copy link
Contributor

-d "--vdev=eth_af_packet0,iface=eth0,--no-huge" fails to parse into two arguments.

Works using a config file.

Root cause is ambiguity with the comma. DPDK uses commas to separate extra fields on a CLI argument. OpenPerf uses commas to separate different DPDK arguments.
DerangedMonkeyNinja added a commit to DerangedMonkeyNinja/openperf that referenced this issue Sep 14, 2020
@DerangedMonkeyNinja
framework: improve command line option parsing
883299a 
Allow multiple map values to contain commas. Only use the last comma
before a key value as a delimiter. Also, strip any extra delimiters in
values.

Additionally, add an explicit option type for parsing command line
options. This allows proper parsing of options for DPDK and resolves
issue Spirent#248.
DerangedMonkeyNinja added a commit to DerangedMonkeyNinja/openperf that referenced this issue Sep 24, 2020
@DerangedMonkeyNinja
framework: improve command line option parsing
c49fa6f 
Allow multiple map values to contain commas. Only use the last comma
before a key value as a delimiter. Also, strip any extra delimiters in
values.

Additionally, add an explicit option type for parsing command line
options. This allows proper parsing of options for DPDK and resolves
issue Spirent#248.
DerangedMonkeyNinja added a commit to DerangedMonkeyNinja/openperf that referenced this issue Oct 16, 2020
@DerangedMonkeyNinja
framework: improve command line option parsing
2ca46bb 
Allow multiple map values to contain commas. Only use the last comma
before a key value as a delimiter. Also, strip any extra delimiters in
values.

Additionally, add an explicit option type for parsing command line
options. This allows proper parsing of options for DPDK and resolves
issue Spirent#248.
DerangedMonkeyNinja added a commit to DerangedMonkeyNinja/openperf that referenced this issue Oct 27, 2020
@DerangedMonkeyNinja
framework: improve command line option parsing
d462991 
Allow multiple map values to contain commas. Only use the last comma
before a key value as a delimiter. Also, strip any extra delimiters in
values.

Additionally, add an explicit option type for parsing command line
options. This allows proper parsing of options for DPDK and resolves
issue Spirent#248.
DerangedMonkeyNinja added a commit that referenced this issue Oct 27, 2020
@DerangedMonkeyNinja
framework: improve command line option parsing
3e80d80 
Allow multiple map values to contain commas. Only use the last comma
before a key value as a delimiter. Also, strip any extra delimiters in
values.

Additionally, add an explicit option type for parsing command line
options. This allows proper parsing of options for DPDK and resolves
issue #248.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmortondev