Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing triangles in 3D view #36

Closed
codehero opened this issue Jan 5, 2014 · 7 comments
Closed

Missing triangles in 3D view #36

codehero opened this issue Jan 5, 2014 · 7 comments

Comments

@codehero
Copy link

codehero commented Jan 5, 2014

My .jscad file shows missing triangles in the 3d previewer and STL output

image
@codehero
Copy link
Author

codehero commented Jan 5, 2014

code is here https://gist.github.com/codehero/8274288

@Spiritdude
Copy link
Contributor

I reduced it to the cylinder (x-axis) substracted from the cube; it's something in the csg.js substract operation: http://sprunge.us/IQPG

@Spiritdude
Copy link
Contributor

This seems to work http://openjscad.org/#http://sprunge.us/XYeQ

@Spiritdude
Copy link
Contributor

Ok, try this http://openjscad.org/#http://sprunge.us/MVbU and enter "Diameter of fork bolt" = 8, but at 8.1 it gives this error with the missing part . . .

@Spiritdude
Copy link
Contributor

I found the problem, make sure the resolution is integer, not a fraction, do resolution: Math.floor(something * something)

@codehero
Copy link
Author

codehero commented Jan 6, 2014

OK cool, thanks for checking it out. Maybe the API should throw an exception if there is a fractional part to the resolution?

@codehero codehero closed this as completed Jan 6, 2014
@Spiritdude
Copy link
Contributor

I just made sure the CSG.*({resolution: something}); is fetched as int.

kaosat-dev added a commit that referenced this issue Apr 19, 2018
@kaosat-dev
feat(geometry caching): add geometry caching & lots more(#38)
3e35d79 
This PR adds & fixes a LOT of things:
* adds initial support for geometry caching (see documentation in README) #34
* adds saving of cache & parameters between launches closes #35  and closes #36
* adds an options panel #37
* fixes error handling : fixes #33
* fixes a lot of minor & less minor issues : fixes #39
* restructures the code to make use of the new @jscad/core package
kaosat-dev pushed a commit that referenced this issue Nov 4, 2019
@z3dev @kaosat-dev
docs:()Last minute changes to README (#36)
591ab45 
modified path to online docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codehero @Spiritdude