Refactor code to check if service worker is enabled #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stance Removed the autowired enabled properties from Manifest and ServiceWorker services. We now directly use the enabled property from the Manifest and ServiceWorker instances. This simplifies the code and allows for better encapsulation and code readability.
Spomky
force-pushed
the
features/better-manifest
branch
from
30cdb60
to
2700833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes all properties that check if a service worker is enabled in favor of checking this directly on the service worker object itself. It affects multiple files and results in a cleaner, more object-oriented approach to determining if the service worker is enabled.
Target branch:
Resolves issue #